[18.0][IMP] subscription_oca : add a setting to choose if the subscription …#1404
[18.0][IMP] subscription_oca : add a setting to choose if the subscription …#1404
Conversation
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and LGTM!
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
From a technical perspective, LGTM.
Would you be open to adding a test covering the change you introduced to the "standard" feature? Before this PR, my understanding from the code is that every newly created subscription automatically started. Now, with your setting, that won't happen by default.
I think adding a test would be a good safety measure—let's see how it goes. You can ping me then.
Also, would you be so kind to review my #1410 in return?
…will start automatically when sale order is conformed or not
cvinh
force-pushed
the
18.0-imp_subscription_oca_no_auto_start
branch
from
3849115 to
3c883ff
Compare
tests added |
|
I don't understand why tests fail |
| "name": "Subscription management", | ||
| "summary": "Generate recurring invoices.", | ||
| "version": "18.0.1.0.0", | ||
| "version": "18.0.1.1.0", |
There was a problem hiding this comment.
I believe the version bump should only apply at merge time—though I could be wrong.
|
@cvinh did you rebase? The tests might pass then. |
4 participants
…will start automatically when sale order is confirmed or not